-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using a Colvars input state file instead of binary checkpoint in GROMACS #610
Conversation
870b610
to
ba18e4e
Compare
9e77b7b
to
3afeaa3
Compare
Note: converting to draft because the first commit undoes the TPR -> EDR change, this is a conflict that needs to be resolved. |
The issue is, LAMMPS lets the user specify new options for each run even after a restart, so if they mention a state file, it should have priority status - whereas Gromacs doesn't, so if a cpt file can be read with success, the state file could be obsolete from a previous run. |
efec113
to
ccfae0d
Compare
Merge conflicts resolved, so I was able to add a needed change, i.e. preventing the GROMACS proxy from setting the initial step of the simulation when it doesn't know it anyway. I think that should be addressed separately, but out of scope for this PR. Also removed the LAMMPS tag since we agreed that the apparent inconsistency is not confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just two suggestions on the documentation.
Also set the proxy version in GROMACS
21eeb6c
to
da5d075
Compare
@jhenin I made the doc edits and restricted the new keyword only to the GROMACS >= 2024 case. I leave open in case you have suggestions about TinkerHP, otherwise I'm good with merging. |
Colvars/Tinker-HP reads a |
See discussion at: https://gitlab.com/gromacs/gromacs/-/merge_requests/3671#note_1577988430
This PR implements that requirement, but in a different manner than was mentioned before: a new keyword internal to the Colvars config file that specifies a state file to be used unless a state is read in any other way, as provided by the MD engine. After the a state is read the first time, the default input state file name is deleted (so that it won't be loaded again).
The new keyword is currently not tested in CI yet. I feel that it would be confusing to expose it to engines other than GROMACS, which don't need it. Currently, it's only documented for that engine. @jhenin What are your thoughts on TinkerHP?
Note below how the two engines that provide their own restart file differ significantly:
keyword, which will be superseded when a checkpoint file is read.colvars-inputstatefile
in the MDPWhile I finish the implementation of this feature for GROMACS, I'd appreciate feedback on whether the above inconsistency should be resolved or not. Mainstream LAMMPS does not contain yet the Colvars code currently inmaster
, so there is time to change.EDIT: see here #610 (comment)