refactor: make mass and width symbols non-negative #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: make meson radius positive
redeboer
added
⚠️ Interface
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
added a commit
to redeboer/ComPWA-tensorwaves
that referenced
this pull request
Mar 31, 2023
Not required anymore since ComPWA/ampform#271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
Assumptions of certain parameter and variable
Symbols in the amplitude model have been updated:nonnegative(used to bereal, and none in thekmatrixmodule)positive(used to bereal)positive(previously none)Helicity angles are still
real=True.Effect on amplitude model
Compare this amplitude on v0.13.3:
with the new one:
