Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update pip constraints and pre-commit #224

Merged
merged 17 commits into from
Dec 9, 2023

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Dec 8, 2023

Automated changes by create-pull-request GitHub action

Closes #223
Ruff was ignoring F821 in Jupyter notebooks. This is not a good idea, because one often makes typos and then only realizes that a variable name is mistyped only once the notebook is run. Now, typos in variable names are flagged.

The reason for ignoring F821 is that cell magic sometimes makes it look like a variable is not defined, which resulted in many false-positives. There is no good solution for this, so the error is now ignored for specific notebooks.

@redeboer redeboer added the 🔨 Maintenance Maintenance and upkeep improvements label Dec 8, 2023
@redeboer redeboer self-assigned this Dec 8, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) December 9, 2023 00:50
@redeboer redeboer merged commit 12682b3 into main Dec 9, 2023
20 checks passed
@redeboer redeboer deleted the create-pull-request/patch-1702050959 branch December 9, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants