Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: sort JSON document case-insensitive #197

Merged
merged 3 commits into from
Oct 6, 2023
Merged

ENH: sort JSON document case-insensitive #197

merged 3 commits into from
Oct 6, 2023

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Oct 6, 2023

If .vscode/settings.json is updated by check-dev-files, the keys are now sorted case-insensitive. This is in accordance with the VSCode command JSON: Sort Document. Setting sort_keys=True in json.dump() is not sufficient, because that sorts case-sensitive.

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Oct 6, 2023
@redeboer redeboer self-assigned this Oct 6, 2023
@redeboer redeboer marked this pull request as ready for review October 6, 2023 14:55
@redeboer redeboer enabled auto-merge (squash) October 6, 2023 14:56
@redeboer redeboer merged commit 1042c08 into main Oct 6, 2023
19 checks passed
@redeboer redeboer deleted the case-insensitive-sorting branch October 6, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redeboer redeboer

Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@redeboer