Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: do not write .binder/apt.txt if no apt packages #443

Merged
merged 1 commit into from
Oct 16, 2024
Merged

FIX: do not write .binder/apt.txt if no apt packages #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/compwa_policy/check_dev_files/binder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,12 @@ def _check_optional_dependencies() -> None:

def _update_apt_txt(apt_packages: list[str]) -> None:
apt_txt = CONFIG_PATH.binder / "apt.txt"
if not apt_packages and apt_txt.exists():
apt_txt.unlink()
msg = f"Removed {apt_txt}, because --doc-apt-packages does not specify any packages."
raise PrecommitError(msg)
if not apt_packages:
if apt_txt.exists():
apt_txt.unlink()
msg = f"Removed {apt_txt}, because --doc-apt-packages does not specify any packages."
raise PrecommitError(msg)
return
apt_packages = sorted(set(apt_packages))
__update_file(
expected_content="\n".join(apt_packages) + "\n",
Expand Down
Loading