MAINT: have qn_domains-keys in Node/EdgeSettings be typed
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayson-helmholz
changed the title
qn_domains-keys in Node/EdgeSettings be the types of the resp. domain qn_domains-keys in Node/EdgeSettings be typed
|
Hopefully merging of #289 will make it easier to have "CI / doc / nb" pass |
redeboer
requested changes
Oct 18, 2024
redeboer
requested changes
Oct 18, 2024
redeboer
requested changes
Oct 18, 2024
redeboer
requested changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have more reliable type-checking the keys of the
qn_domains-dictionary should be the types of the respective domains themselves. This avoids for example the use of wrong quantum numbers (EdgeQNs for a node, etc.)Closes #281