Fixes for Crystal Ship and FTLFrame NPE #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved LaF code in a shot-in-the-dark attempt to fix this issue, where com.sun.java.swing.plaf.windows.XPStyle.getTypeEnumName() causes a NullPointerException. |
|
I have partially merged your changes. The LnF issue is a bug in Java when using a custom Windows theme, so your change would not solve it. You have a point about the clutter in that constructor, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAYER_SHIP_CRYSTAL_2 was being omitted because, in blueprints xml, there was an unterminated comment above it.
This fixes the following issue.
#5
Changing Look and Feel in the JFrame constructor may have caused an NPE.
#7
I moved that, which I think is good practice anyway.