Updated BuildCompat.py

[Akilak11]

added:

1. Asynchronous execution: Use asyncio.create_subprocess_exec to start processes and wait for them to complete asynchronously.
2. File reading optimization: Reading a file line by line inside an asynchronous function.
3. Asynchronous task management: Use asyncio.gather to execute commands in parallel if the -j flag is enabled. This approach allows multiple processes to run in parallel, effectively managing their termination, which should improve script performance.

Additions

Describe new functionality added by your code, e.g.

• Tribal smoke bombs
• New tribal smoke bomb sprite
• Tribal smoke bomb recipes at smithing bench and crafting spot using prometheum

Changes

Describe adjustments to existing features made in this merge, e.g.

• Increased regular smoke bomb radius

References

Links to the associated issues or other related pull requests, e.g.

• Closes #[ISSUE_NUMBER]
• Contributes towards #[ISSUE_NUMBER]

Reasoning

Why did you choose to implement things this way, e.g.

• Tribals need ways to close distance with pirate raiders
• Smoke bombs allow this while enhancing combat micro
• Thematically appropriate as we already allow tribal prometheum handling
• Easy to implement
• Buffed regular smoke grenades as they are rarely utilized and to justify additional investment

Alternatives

Describe alternative implementations you have considered, e.g.

• Tribal catapult that launches melee animals into siege camps:
  • Additional use for animals
  • Anachronistic
  • Breaks realism theme

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• (For compatibility patches) ...with and without patched mod loaded
• Playtested a colony (specify how long)

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9616442798.zip

[perkinslr]

It is worth noting that joinpath does not sanitize input, so this does not enforce that csproj_path is a child of "Source". It does not appear that pathlib has a way to enforce that constraint. In this case, I don't see an obvious attack vector exposed by relaxing this constraint, and FilePath is the only thing we're using out of tiwsted, so removing it makes the code more portable (as pathlib is part of the standard library).

[perkinslr]

This exits non-zero even in parallel build mode. That is probably a good thing as it would let us use parallel mode in the github action and not incorrectly ship a broken build. However it leaves the other tasks hanging. They then spew their standard out and standard error messages after the main script terminates.

The return values from run_command are accumulated by asyncio.gather, so run_command should simply return the failure code, and its caller should check that error code and handle it. This could be done via try/except, assuming asyncio can be told to wait on all even after the first exception is thrown, but that does not appear to be the default from asyncio.gather. Printing a summary (passed / total) at the end is probably the correct solution.