Hide disabled ammo from research #3604
Open
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12447513714.zip |
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12448948333.zip |
AluminumAlman
approved these changes
Jan 4, 2025
| { | ||
| pair.second.RemoveWhere(x => x is AmmoDef ammoDef && ammoDef.menuHidden); | ||
| } | ||
| input.RemoveWhere(x => x.second.NullOrEmpty()); |
There was a problem hiding this comment.
What's exactly the point of removing empty research unlock headers? So that if research ends up unlocking nothing, that it wouldn't have the text "Unlock:" with nothing after?
There was a problem hiding this comment.
yeah, pretty much, the heavy weapons research unlocks the 105mm shells, which were disabled, but the header still shows up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Reasoning
Alternatives
Testing
Check tests you have performed: