Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed scrollbar issue #64

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Fixed scrollbar issue #64

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e87d1d
Fixed scrollbar issue
Kandles11 Dec 1, 2023
ee7733f
Changed chessboard to scale based on size
AlexKempen Dec 1, 2023
6f8a888
Fixed scrollbar issue
Kandles11 Dec 1, 2023
0f8fa45
Changed chessboard to scale based on size
AlexKempen Dec 1, 2023
15f5f95
Merge branch '62-scroll-bars-appear-on-chessboard' of https://github.…
AlexKempen Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/client/chessboard-wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ interface Transform {
left: number;
}

function computeChessboardTransform(canvasHeight: number, canvasWidth: number): Transform {
// We need exactly 7 less pixels to prevent scrollbars from appearing...
const width = Math.min(canvasHeight, canvasWidth) - 7;
function computeChessboardTransform(canvasHeight: number, canvasWidth: number, scale: number): Transform {
// Alternative: subtract off at least 8 to prevent scrollbars
const width = Math.min(canvasHeight, canvasWidth) * scale;
const height = width;

const xShift = (canvasWidth - width) / 2;
const yShift = (canvasHeight - height) / 2; // + height;
const yShift = (canvasHeight - height) / 2;
return { left: xShift, top: yShift, height, width };
}

Expand All @@ -34,7 +34,7 @@ export function ChessboardWrapper(props: ChessboardWrapperProps): JSX.Element {

const handleResize = (entries: ResizeEntry[]) => {
const { height, width } = entries[0].contentRect;
const transform = computeChessboardTransform(height, width);
const transform = computeChessboardTransform(height, width, 0.85);
setTransform(transform);
};

Expand Down
Loading