Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger node def locale update manually #2170

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Trigger node def locale update manually #2170

merged 2 commits into from
Jan 6, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 5, 2025 •
edited
Loading

Resolves #2132

This PR splits the github action of update locale into

  • i18n-general: Update locale of content in the frontend repo
  • i18n-node-defs: Update locale of node defs (Determined by the ComfyUI main repo)

The update node-defs locale action should be triggered manually once before the version we want to publish to the main repo.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner January 5, 2025 21:27
@huchenlei huchenlei merged commit e82d795 into main Jan 6, 2025
10 checks passed
@huchenlei huchenlei deleted the disable_node_def_locale branch January 6, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DevTask] Trigger locale update from ComfyUI main repo
1 participant
@huchenlei