Add output explorer #2337
Open
Add output explorer #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayden-fr
requested review from
Yorha4D,
KarryCharon,
DorotaLuna,
shinshin86 and
a team
as code owners
|
This is extremely high-quality output-explorer-demo.mp4 |
Comment on lines
+68
to
+74
| type Item = { | ||
| key: string | ||
| name: string | ||
| type: string | ||
| modifyTime: number | ||
| size: number | ||
| } |
There was a problem hiding this comment.
I think it's best to adjust the associated backend PR to return items using an extension of ResultItem, for consistency.
We can create a more generalized version of the current ResultItemImpl class that excludes properties like nodeId and vhsAdvancedPreviewUrl. This class can serve as a base for both result items and output items.
Then we can move ResultGallery to common components and it can be used by OutputExplorerSidebarTab.
There was a problem hiding this comment.
Do you mean I need to create a new ResultItemImpl class or just improve the current one is OK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Notion page by Unito