-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lib] Introduce
MinimallyEncodedMemberInfo
and validator
Summary: `MemberInfo` type w/ `permissions` as string instread of `ThreadPermissions`. Next diffs: - Introduce `MinimallyEncodedRawThreadInfo` - Higher level utilities for translating back/forth from `RawThreadInfo` <=> `MinimallyEncodedRawThreadInfo`. Found this to be cleaner API than encoding/decoding `RawThreadInfo.currentUser.permissions` and `RawThreadInfo.members[memberID].permissions` "manually" a bunch of different places. - Native refactoring + migrations - Web refactoring - Flipping the switch --- Depends on D9734 Test Plan: Unit tests, will be tested implicitly in subsequent diffs as well. Reviewers: ashoat, ginsu, tomek, rohan Reviewed By: ashoat Subscribers: wyilio Differential Revision: https://phab.comm.dev/D9735
- Loading branch information
1 parent
dc24c82
commit 8485f33
Showing
3 changed files
with
58 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters