[CI] Use new API version

Summary:
The API we're using was disabled nad we need to use a more recent version.

https://linear.app/comm/issue/ENG-10136/github-actions-fail-because-of-an-deprecated-api

Depends on D14286

Test Plan: Tested it directly on GitHub, but a different (sing-related) error appears, so I'll try to test it by landing on master.

Reviewers: kamil, bartek

Reviewed By: bartek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D14287

.github/workflows/macos_ci.yml

@@ -69,7 +69,7 @@ jobs:
         run: yarn make --arch universal
 
       - name: Upload Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: macos-artifacts
           path: ./desktop/out/make/**/*

.github/workflows/windows_ci.yml

@@ -41,7 +41,7 @@ jobs:
         run: yarn make
 
       - name: Upload Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: windows-artifacts
           path: ./desktop/out/make/**/*