Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[landing] Introduce a loading state to SIWE component
Summary: After clicking the button, we need to make sure that a user can't interact with it again and is aware that an operation is in progress. | old | new | | {F3851157} | {F3851163} | We could introduce a loading state containing some indicator, but we don't have anything similar on the web and the landing, so it probably isn't worth it to introduce just for this case. Also, I considered using a common button component from the web by extracting it to the lib. This would require a lot of design decisions because the web colors and margins don't always match what we have on the landing and the native - where the SIWE component is displayed. Another consideration was to use the `Button` component from the landing, but it is so simple that it wouldn't be beneficial. So overall, there were some opportunities to reduce code duplication, but I don't think they are worth it now. https://linear.app/comm/issue/ENG-10080/introduce-a-loading-status-to-the-sign-in-button-on-siwe-landing-page Test Plan: Checked on iOS simulator that the button state changes and it isn't possible to click it multiple times. Reviewers: kamil, angelika Reviewed By: kamil Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14248
- Loading branch information