Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MailPit support #476 #479

Merged
merged 1 commit into from
Feb 19, 2025
Merged

feat: add MailPit support #476 #479

merged 1 commit into from
Feb 19, 2025

Conversation

prom3theu5
Copy link
Contributor

@prom3theu5 prom3theu5 commented Feb 17, 2025 •
edited
Loading

This pull request adds support for a MailPit integration, including unit tests.

Documentation has been created under the PR: dotnet/docs-aspire#2633

This fulfils the proposal outlined in #476

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@prom3theu5
Copy link
Contributor Author

@dotnet-policy-service agree

aaronpowell
aaronpowell approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration looks all good. @prom3theu5 are you willing to be added as the CODEOWNER of the integration?

@prom3theu5
Copy link
Contributor Author

Hi @aaronpowell
Yeah sure thats fine

@aaronpowell
Copy link
Member

Invite sent

@aaronpowell aaronpowell merged commit 537fc3d into CommunityToolkit:main Feb 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronpowell aaronpowell aaronpowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prom3theu5 @aaronpowell