Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 info page Pull Request #5

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

5 info page Pull Request #5

wants to merge 26 commits into from

Conversation

ComparatorCraftSMP
Copy link
Collaborator

No description provided.

@ComparatorCraftSMP
Copy link
Collaborator Author

Laguna just a few things

1st.
image
I've added a js script that would auto update the player count in each of the servers

2nd
image
Your supposed to click that to copy the ip addresses but I couldn't get it aligned well :/

@LagunaElectric
Copy link
Collaborator

LagunaElectric commented Aug 20, 2021 via email

@LagunaElectric
Copy link
Collaborator

https://gyazo.com/8342579eb3b8f26d8c05d5e9aed20c3c

When the px value is 0 you don't have to put px after it :) Remove the px from the lines in the screenshot, and ignore the other two errors for now.

@ComparatorCraftSMP
Copy link
Collaborator Author

Fixed everything can I merge the pull request?

@@ -3278,4 +3278,194 @@ body.is-touch #banner {
margin: 0;
padding: 0;
}
}

/* style for flipping card starts here */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you find this CSS?

@@ -578,4 +578,12 @@

function toggleSidePanel() {
$('body').toggleClass('navPanel-show');
}

function copyToClipboard(element) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get this function?

</div>
</div>
</section> -->
<hr>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you catch this


tag in the commented out section.


</body>

</html>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of your files should end in a blank new line.

<thead>
<tr>
<th>Tweak</th>
<th>Description</th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These headers need to be styled. We'll work on that together, just get with me sometime this week.

$("body").append($temp);
$temp.val($(element).text()).select();
document.execCommand("copy");
$temp.remove();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of your files should end in a new line.

position: absolute;
top: 40%;
left: 50%;
transform: translate(-50%, -50%);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of your files should end in a new line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants