Improve snapshot handling in automatus #13138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using "to" in "reverting to snapshot" better describes the actual activity. The name of the function is also `revertToSnapshot`.
We revert to the snapshot after each test. When we want to delete the snapshot, we don't have to revert to the snapshot again, because we reverted to the snapshot right before it, so we can simply only delete it. This can save some time.
|
Code Climate has analyzed commit 1c53cd5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using "to" in "reverting to snapshot" better describes the actual
activity. The name of the function is also
revertToSnapshot.We revert to the snapshot after each test. When we want to delete
the snapshot, we don't have to revert to the snapshot again, because
we reverted to the snapshot right before it, so we can simply only
delete it. This can save some time.