-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable remediations for set_iptables_default_rule and set_ip6tables_default_rule on Ubuntu products #13139
Disable remediations for set_iptables_default_rule and set_ip6tables_default_rule on Ubuntu products #13139
Conversation
Disable remediations for set_iptables_default_rule and set_ip6tables_default_rule on Ubuntu products as it can result in network lockout. New behavior is consistent with analogous nftables and ufw rules nftables_ensure_default_deny_policy and set_ufw_default_rule.
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_set_iptables_default_rule'.
--- xccdf_org.ssgproject.content_rule_set_iptables_default_rule
+++ xccdf_org.ssgproject.content_rule_set_iptables_default_rule
@@ -6,7 +6,9 @@
To set the default policy to DROP (instead of ACCEPT) for
the built-in INPUT chain which processes incoming packets,
add or correct the following line in
+
/etc/sysconfig/iptables:
+
:INPUT DROP [0:0]
[reference]: |
Code Climate has analyzed commit a6d2564 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.1% (0.0% change). View more on Code Climate. |
Automatus tests are failing due to iptables not working in podman containers. Ubuntu 24.04 VM:
Ubuntu 22.04 VM:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
set_iptables_default_rule
andset_ip6tables_default_rule
on Ubuntu productsRationale: