Update release script based on new stabilization date #13140
Conversation
|
Code Climate has analyzed commit f49cfc6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.1% (0.0% change). View more on Code Climate. |
| first_day_weekday = first_day_of_month.weekday() | ||
| first_monday_date = 1 + (0 - first_day_weekday) % 7 | ||
| third_monday_date = first_monday_date + 14 | ||
| return datetime(year, month, third_monday_date) |
There was a problem hiding this comment.
You need to add time zone info
| return datetime(year, month, third_monday_date) | |
| return datetime(year, month, third_monday_date, tzinfo=UTC) |
Otherwise you will get TypeError: can't compare offset-naive and offset-aware datetimes on line 366.
There was a problem hiding this comment.
What version of Python are you using? Using 3.11 and 3.13 I'm running into this and this suggested change causes more issues.
There was a problem hiding this comment.
On line 366 you compare the returned value with now which is now = datetime.now(UTC). Happens only if the month is greater than 9 therefore in Q4.
Description:
Since #13119 has been merged we should update the helper script to match.
Rationale:
Keeping helper scripts up-to-date with policies.
Review Hints:
./utils/release_helper.py stats