Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change peer dependency version, one type fix and add langgraph in ts docs #1209

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
15 changes: 8 additions & 7 deletions js/package.dist.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,14 @@
"author": "Utkarsh Dixit <[email protected]>",
"license": "ISC",
"peerDependencies": {
"ai": "^3.2.22",
"@ai-sdk/openai": "^0.0.36",
"@cloudflare/workers-types": "^4.20240718.0",
"@langchain/core": "^0.2.18",
"@langchain/openai": "^0.2.5",
"langchain": "^0.2.11",
"openai": "^4.50.0"
"ai": ">3.0",
"@ai-sdk/openai": ">0.0.36",
"@cloudflare/workers-types": ">4.0",
"@langchain/core": ">0.2.0",
"@langchain/openai": ">0.2.0",
"langchain": ">0.2.0",
"openai": ">4.0",
"resolve-package-path": "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using * for versioning in peer dependencies. Specify a version range for resolve-package-path to ensure compatibility.

},
"dependencies": {
"chalk": "^4",
Expand Down
17 changes: 9 additions & 8 deletions js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@
"author": "Utkarsh Dixit <[email protected]>",
"license": "ISC",
"peerDependencies": {
"@ai-sdk/openai": "^0.0.36",
"@cloudflare/workers-types": "^4.20240718.0",
"@langchain/core": "^0.2.18",
"@langchain/openai": "^0.2.5",
"ai": "^3.2.22",
"langchain": "^0.2.11",
"openai": "^4.50.0"
"ai": ">3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using > version constraints for peer dependencies could lead to unexpected compatibility issues if major versions introduce breaking changes. Consider:

  1. Using ^ for minor version flexibility while preventing major version jumps
  2. Using more specific ranges like >4.0.0 <5.0.0
  3. Documenting the testing strategy for version compatibility

"@ai-sdk/openai": ">0.0.36",
"@cloudflare/workers-types": ">4.0",
"@langchain/core": ">0.2.0",
"@langchain/openai": ">0.2.0",
"langchain": ">0.2.0",
"openai": ">4.0"
},
"dependencies": {
"axios": "^1.7.2",
Expand All @@ -53,7 +53,8 @@
"rollup-plugin-visualizer": "^5.13.1",
"uuid": "^10.0.0",
"zod": "^3.23.8",
"zod-to-json-schema": "^3.23.2"
"zod-to-json-schema": "^3.23.2",
"resolve-package-path": "*"
},
"devDependencies": {
"@eslint/js": "^9.16.0",
Expand Down
Loading
Loading