-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin autogen and langgraph-prebuilt #1375
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM 👍 |
8caec7f
to
896ea44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 896ea44 in 48 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .github/workflows/examples.yml:96
- Draft comment:
Ensure combined installation of packages with version constraints is intentional. Verify that installing 'ag2[openai]' and 'langgraph-prebuilt>=0.1.0' alongside the other packages in a single pip invocation does not lead to dependency conflicts. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
2. .github/workflows/examples.yml:96
- Draft comment:
Ensure the combined pip install command (adding 'ag2[openai]' and 'langgraph-prebuilt>=0.1.0') works as intended. Consider verifying that the extra specifiers (especially bracket notation) are correctly interpreted in this YAML context and that version pinning (if needed) is handled. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_wp38RY5KOrOokYq5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 8caec7f in 1 minute and 56 seconds
More details
- Looked at
28
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. .github/workflows/examples.yml:93
- Draft comment:
Removed '--upgrade pip' may result in an outdated pip version. Confirm if this change was intentional. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
- The comment is about a changed line. 2. 'uv' is a modern alternative to pip that handles dependencies differently. 3. When using uv, upgrading pip separately is not necessary as uv manages package installation directly. 4. The comment shows lack of understanding of uv's functionality. 5. The change is actually an improvement in dependency management.
I might be assuming too much about uv's functionality. There could be edge cases where having an updated pip is still important.
Even if there were edge cases, the comment is asking for confirmation of intention rather than pointing out a clear issue, which violates our review rules.
Delete the comment because it asks for confirmation of intention and shows misunderstanding of the uv tool being used.
2. .github/workflows/examples.yml:98
- Draft comment:
Run commands no longer set COMPOSIO environment variables inline; ensure the env section suffices in all contexts. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the author to ensure that the environment section is sufficient in all contexts, which is a form of asking for confirmation or verification. This violates the rule against asking the PR author to ensure or verify things.
3. .github/workflows/examples.yml:90
- Draft comment:
Added COMPOSIO_LOGGING_LEVEL='debug'. Confirm that a static 'debug' level is intended for all runs and doesn’t override dynamic settings. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
The comment asks for confirmation about intention, which violates our rules explicitly. It's asking "Confirm that..." which is listed as a type of comment we should not make. The change appears to be a deliberate refactoring to simplify the test commands, and we should trust the author's intention unless there's a clear technical problem.
Maybe the logging level could impact test results or debugging capabilities in production? Maybe there's a good reason to keep it configurable?
While logging levels can be important, asking for confirmation of intention is not actionable. If there was a specific technical problem with debug logging, that would be different, but this is just questioning a choice.
Delete the comment as it violates our rule against asking authors to confirm their intentions or explain their choices.
4. .github/workflows/examples.yml:93
- Draft comment:
Removed 'python -m uv pip install --upgrade pip pytest'. Consider if an explicit pip upgrade is needed to avoid issues with outdated pip. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
- They're using uv instead of pip directly. 2. uv is a modern package installer that handles dependencies better than pip. 3. When using uv, explicitly upgrading pip is unnecessary since uv manages package installation. 4. The change actually simplifies and improves the installation process.
I could be wrong about uv's behavior - maybe it still relies on pip's version under the hood? The comment suggests there could be dependency issues without the pip upgrade.
uv is specifically designed to replace pip and handle dependencies more reliably. Since they've switched fully to uv commands, pip's version is no longer relevant to the package installation process.
The comment should be deleted because it raises concerns about a removed pip upgrade that's unnecessary when using uv for package management.
5. .github/workflows/examples.yml:94
- Draft comment:
Using 'uv pip install' (without 'python -m') assumes 'uv' is in PATH. Confirm that this command is reliably available. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm the availability of a command, which violates the rule against asking for confirmation or verification. It does not provide a specific code suggestion or ask for a test to be written.
6. .github/workflows/examples.yml:95
- Draft comment:
Multiple packages are installed together before '.[all]'. Ensure that installing '.[all]' later does not override or conflict with these dependencies. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =30%
<= threshold50%
The comment is about dependency management, specifically about the order of installation and potential conflicts. It suggests ensuring that installing '.[all]' does not override or conflict with other dependencies. This is a specific suggestion related to dependency management, which is generally not allowed according to the rules. However, it does not directly ask the author to confirm or double-check, but rather to ensure a specific outcome. This makes it a borderline case, but it leans towards being disallowed because it indirectly asks for confirmation of behavior.
7. .github/workflows/examples.yml:98
- Draft comment:
Inline env overrides (e.g. CI, COMPOSIO_*) were removed from the test commands. Verify that tests receive all necessary environment variables solely from the step 'env' block. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify that tests receive all necessary environment variables from a specific source. This falls under the category of asking the author to ensure something is tested or verified, which is against the rules.
Workflow ID: wflow_VomrZewH96Gwispr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
896ea44
to
000e2b2
Compare
@@ -94,7 +94,7 @@ jobs: | |||
python -m uv pip install plugins/${{ matrix.package }} | |||
python -m uv pip install '.[all]' | |||
python -m uv pip install 'numpy<2' python-dotenv | |||
python -m uv pip install unstructured | |||
python -m uv pip unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid pip
command syntax - python -m uv pip unstructured
is missing install
command which will cause installation failure
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
python -m uv pip unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0' | |
python -m uv pip install unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 000e2b2 in 1 minute and 31 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .github/workflows/examples.yml:97
- Draft comment:
It looks like the 'install' subcommand has been omitted. The other pip commands use 'python -m uv pip install ...'. Should this line be 'python -m uv pip install unstructured ag2[openai] "langgraph-prebuilt>=0.1.0"'? - Reason this comment was not posted:
Marked as duplicate.
2. .github/workflows/examples.yml:97
- Draft comment:
Typographical error: The command on line 97 is missing the 'install' keyword. It currently reads "python -m uv pip unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0'"; it should likely be "python -m uv pip install unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0'" to be consistent with the other pip commands. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_atnaufdNiNlClSuR
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -94,7 +94,7 @@ jobs: | |||
python -m uv pip install plugins/${{ matrix.package }} | |||
python -m uv pip install '.[all]' | |||
python -m uv pip install 'numpy<2' python-dotenv | |||
python -m uv pip install unstructured | |||
python -m uv pip unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the 'install' keyword in the pip command; should be 'python -m uv pip install unstructured ...'.
python -m uv pip unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0' | |
python -m uv pip install unstructured ag2[openai] 'langgraph-prebuilt>=0.1.0' |
Important
Pins
langgraph-prebuilt
to>=0.1.0
and addsag2[openai]
inexamples.yml
.langgraph-prebuilt
to version>=0.1.0
inexamples.yml
.ag2[openai]
to the list of installed packages inexamples.yml
.This description was created by
for 000e2b2. It will automatically update as commits are pushed.