Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin pydantic version to less than 2.10.0 #1385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreysingla11
Copy link
Collaborator

@shreysingla11 shreysingla11 commented Mar 3, 2025

Breaking change in pydantic version 2.10.0.


Important

Pin pydantic version to <2.10.0 in setup.py to avoid breaking changes.

  • Dependencies:
    • Pin pydantic version to >=2.6.4,<2.10.0 in setup.py to avoid breaking changes introduced in version 2.10.0.

This description was created by Ellipsis for 71c8773. It will automatically update as commits are pushed.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 8:06am

Copy link

LGTM 👍

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 71c8773 in 1 minute and 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. python/setup.py:41
  • Draft comment:
    Pinning pydantic to <2.10.0 is correct. Consider adding an inline comment explaining the breaking change in pydantic v2.10.0 for future clarity.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
    According to the rules, we should not comment on dependency changes or versions we don't recognize. The comment is purely informative and doesn't require any code changes - it's just suggesting adding documentation. The PR author clearly knew what they were doing since they specifically pinned the version.
    Maybe having documentation about breaking changes in dependencies is actually important for maintainability? Maybe this would save future developers time?
    While documentation can be helpful, the rules clearly state not to comment on dependency changes or make purely informative comments. The version constraint itself serves as documentation of the limitation.
    This comment should be deleted as it violates the rules about not commenting on dependency changes and not making purely informative comments.
2. python/setup.py:41
  • Draft comment:
    Pinning pydantic to <2.10.0 is appropriate for avoiding breaking changes in v2.10.0. Consider adding a comment or updating the changelog to document this constraint.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment suggests adding documentation for a dependency version constraint, which is not allowed by the rules. It also provides information about the reason for pinning the version, which is purely informative. Therefore, this comment should be removed.
3. python/setup.py:2
  • Draft comment:
    Typo in the module docstring on line 2: 'Setup configuration for compsio core.' should likely read 'Setup configuration for composio core.' to maintain consistency with the project name.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_X1jsL0rcC0M0dg3B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant