Allow deployment slot settings #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve support for slots, including copying appsettings and adding m…
Made slot copy all site settings and overwrite/merge those it cares about
fixed tests depending on order of generated resources
Merge from upstream
Slots merge identity
The only config option is the path, the "time before unhealthy instances are removed" option isn't configurable via ARM.
Add health check support
- refactored match this.CustomDomain statement - edited releasenotes - edited docs ... resources/web-app.md
- eval at arm level, used for the resourceGroup property - builders resourcegroup/app changed to acocomodate ArmExpression name type change - NoDomain changed
…t stays coated with extra quote marks - amended test to reflect that
Revert "Custom domains for Web App"
Slots should not have a Zip Deploy as a PostDeployTask
- Web.fs : Added Certificate, HostnameBinding and SSlState types - Builders.WebApp.fs : Builder now consideres CustomDomain property (SecureDomain, InsecureDomain, NoDomain) - Types.fs : DomainConfig and CertificateOptions created as part of the CustomDomain property use in the WebApp builder ##Minor Changes - resourceGroup.fs : Minor change to accomodate "[resourceGroup().name]" name in WebApp builder ##Comments/Concerns - On testing the creation of an app managed certificate, I noticed that the thumbprint of the certificate createddoesn't show in the UI and the resource itself (when accessing resources.azure.com), I then saw [this article](https://docs.microsoft.com/en-us/azure/app-service/configure-ssl-certificate#:~:text=Does%20not%20support%20usage%20as%20a%20client%20certificate%20by%20certificate%20thumbprint%20(removal%20of%20certificate%20thumbprint%20is%20planned).) which probably explains why. All tests ran fine.
Custom domain without name type change
update cert dependancy to not need service plan Id
Merge from compositionalIT/farmer
Fix function unmanaged refs cdt
Merge from compositionalIT/farmer
Add dotnet 6 webapp support
|
there was some mess with the branch when I tried to merge the changes to my organization. I will re-open a new one later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #838
The changes in this PR are as follows:
slot_settingandslot_settingsI have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here: