Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused includes of pthread #3040

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Remove unused includes of pthread #3040

merged 1 commit into from
Aug 28, 2019

Conversation

sbastrakov
Copy link
Member

This has been spotted during the investigation of #3037 (but is unrelated to that issue).

Now the core code of PIConGPU does not include or use pthread, only cuda_memtest and alpaka do.

@sbastrakov sbastrakov added component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API labels Aug 28, 2019
@sbastrakov sbastrakov added this to the 0.5.0 / 1.0.0: Next Stable milestone Aug 28, 2019
@ax3l
Copy link
Member

ax3l commented Aug 28, 2019

Thx, that's outdated.
In the past we used a thread for I/O, but actually only MPI implementations today are threadsafe to do so ;)

@ax3l ax3l merged commit f3482b8 into ComputationalRadiationPhysics:dev Aug 28, 2019
@ax3l ax3l self-assigned this Aug 28, 2019
@sbastrakov sbastrakov deleted the fix-removeLeftoverPthreadIncludes branch August 29, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sbastrakov @ax3l