Queries for getting which accounts have scheduled releases or cooldowns. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
approved these changes
Nov 25, 2024
| - Add `GetScheduledReleaseAccounts` endpoint for querying the list of accounts that | ||
| have scheduled releases. | ||
| - Add `GetCooldownAccounts`, `GetPreCooldownAccounts` and `GetPrePreCooldownAccounts` | ||
| endpoints for querying the lists of account that have pending cooldowns in protocol |
There was a problem hiding this comment.
Suggested change
| endpoints for querying the lists of account that have pending cooldowns in protocol | |
| endpoints for querying the lists of accounts that have pending cooldowns in protocol |
| @@ -174,6 +174,25 @@ service Queries { | |||
| // Get next available sequence numbers for updating chain parameters after a given block. | |||
| rpc GetNextUpdateSequenceNumbers (BlockHashInput) returns (NextUpdateSequenceNumbers); | |||
|
|
|||
| // Get all accounts that have scheduled releases, with the timestamp of the first pending | |||
| // scheduled release for that account. (Note, this only identifies accounts by index, and | |||
There was a problem hiding this comment.
Suggested change
| // scheduled release for that account. (Note, this only identifies accounts by index, and | |
| // scheduled release for that account. (Note, this only identifies accounts by index, and |
| // Prior to protocol version 7, the resulting stream will always be empty. | ||
| rpc GetCooldownAccounts (BlockHashInput) returns (stream AccountPending); | ||
|
|
||
| // Get all accounts (by account index) that have stake in pre-cooldown. |
There was a problem hiding this comment.
To be consistent, minor nitpicking:
Suggested change
| // Get all accounts (by account index) that have stake in pre-cooldown. | |
| // Get all accounts that have stake in pre-cooldown. (Note, this only identifies accounts by index). |
| // Prior to protocol version 7, the resulting stream will always be empty. | ||
| rpc GetPreCooldownAccounts (BlockHashInput) returns (stream AccountIndex); | ||
|
|
||
| // Get all accounts (by account index) that have stake in pre-pre-cooldown. |
There was a problem hiding this comment.
Suggested change
| // Get all accounts (by account index) that have stake in pre-pre-cooldown. | |
| // Get all accounts that have stake in pre-pre-cooldown. (Note, this only identifies accounts by index). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add gRPC endpoints for getting the lists of accounts with scheduled releases or cooldowns.
Changes
Checklist
hard-to-understand areas.