Add contract modules and contract instances #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
DOBEN
force-pushed
the
rust-backend-modules
branch
from
285590f to
ef769d3
Compare
DOBEN
force-pushed
the
rust-backend-modules
branch
from
ef769d3 to
ffc4025
Compare
Victor-N-Suadicani
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Not anything seriously blocking but various suggestions and questions.
In general I also feel there is a lack of comments, would be nice with more. But remember to make the comments say something that isn't already said by the code itself. Repeating what the code is already saying is not useful.
limemloh
reviewed
Oct 16, 2024
DOBEN
force-pushed
the
rust-backend-modules
branch
from
3dd81f5 to
b758d16
Compare
DOBEN
force-pushed
the
rust-backend-modules
branch
from
b758d16 to
32edfec
Compare
limemloh
approved these changes
Oct 21, 2024
Comment on lines
+860
to
+881
| let snapshot = ContractSnapshot { | ||
| block_height: row.block_height, | ||
| contract_address_index, | ||
| contract_address_sub_index, | ||
| contract_name: row.contract_name, | ||
| module_reference: row.module_reference, | ||
| amount: row.amount, | ||
| }; | ||
|
|
||
| let contract = Contract { | ||
| contract_address_index, | ||
| contract_address_sub_index, | ||
| contract_address: format!( | ||
| "<{},{}>", | ||
| contract_address_index, contract_address_sub_index | ||
| ), | ||
| creator: row.creator.into(), | ||
| block_height: row.block_height, | ||
| transaction_hash: row.transaction_hash, | ||
| block_slot_time: row.block_slot_time, | ||
| snapshot, | ||
| }; |
There was a problem hiding this comment.
Not exactly what I meant, but let's keep it like this for now, I can make a small PR to show what I mean.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses #252
Addresses #250
Addresses #253
Changes
contractandmoduletable.Query::module.Query::contract.Query::contracts.