Run P7 delegator migrations at every P7 block instead of only payday #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
approved these changes
Oct 30, 2024
soerenbf
reviewed
Oct 30, 2024
Comment on lines
+38
to
+45
| } else if (payload.BlockInfo.ProtocolVersion == ProtocolVersion.P7) { | ||
| // Starting from Concordium Protocol Version 7 stake changes are immediate, | ||
| // meaning no delegators are expected to have pending changes from this point. | ||
| // Only the block in P7 should this do anything, afterwards it is a | ||
| // no-op, since no accounts with pending changes are expected. | ||
| await _writer.UpdateAccountsWithPendingDelegationChange(DateTimeOffset.MaxValue, | ||
| account => ApplyPendingChange(account, resultBuilder)); | ||
|
|
There was a problem hiding this comment.
Not a blocker, but could be:
Suggested change
| } else if (payload.BlockInfo.ProtocolVersion == ProtocolVersion.P7) { | |
| // Starting from Concordium Protocol Version 7 stake changes are immediate, | |
| // meaning no delegators are expected to have pending changes from this point. | |
| // Only the block in P7 should this do anything, afterwards it is a | |
| // no-op, since no accounts with pending changes are expected. | |
| await _writer.UpdateAccountsWithPendingDelegationChange(DateTimeOffset.MaxValue, | |
| account => ApplyPendingChange(account, resultBuilder)); | |
| } else if (payload.BlockInfo.ProtocolVersion >= ProtocolVersion.P7) { | |
| // Starting from Concordium Protocol Version 7 stake changes are immediate, | |
| // meaning no delegators are expected to have pending changes from this point. | |
| // Only the block in P7 should this do anything, afterwards it is a | |
| // no-op, since no accounts with pending changes are expected. | |
| await _writer.UpdateAccountsWithPendingDelegationChange(DateTimeOffset.MaxValue, | |
| account => ApplyPendingChange(account, resultBuilder)); | |
Also seems to reflect the comment more precisely?
There was a problem hiding this comment.
This is migrating state from P6 to P7, so when we get to P8 it does not need to be run.
Ideally we would not run it more than once, either but this was quick solution.
| } else if (payload.BlockInfo.ProtocolVersion == ProtocolVersion.P7) { | ||
| // Starting from Concordium Protocol Version 7 stake changes are immediate, | ||
| // meaning no delegators are expected to have pending changes from this point. | ||
| // Only the block in P7 should this do anything, afterwards it is a |
There was a problem hiding this comment.
Suggested change
| // Only the block in P7 should this do anything, afterwards it is a | |
| // Only the first block in P7 should this do anything, afterwards it is a |
?
There was a problem hiding this comment.
yes, that is what I meant to write 😅 maybe I'll fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix bug preventing the ingestion from proceeding.
The issue was that delegators with pending changes from P6 were not migrated immediately in P7, as the migration logic was only run at payday.
This PR changes the migration logic to be run at every block ingested in P7.