Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for CCD Scan Protocol 6 update regression test #89

Merged
7 commits merged into from
Aug 14, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2023

Purpose

Bug fixes found at regression test related to protocol 6 updates.

Changes

  • https://concordium.atlassian.net/browse/CBW-1238
    https://concordium.atlassian.net/browse/CBW-1237
    https://concordium.atlassian.net/browse/CBW-1229
    • Exception was thrown when asking for passive delegation is chain parameters wasn’t version 1. In protocol 6 we have chain parameter version 2 which had the exception thrown. Fix this.
    • Due to currently a short durations of payday cycle APY’s explode. In the DB columns was numeric which couldn’t be parsed to C# doubles.
      A related fix for a view has already been done for migration 0041, and same fix, changing columns to type double in DB, has now been done for affected table.
  • Fx file permissions on keep_alive.sh needed for DB restore which by mistake changed in former PR.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

@ghost ghost requested a review from ali-concordium August 10, 2023 20:13
@orhoj orhoj self-requested a review August 14, 2023 07:03
@orhoj orhoj assigned ghost Aug 14, 2023
@ghost ghost merged commit c7553c5 into main Aug 14, 2023
@ghost ghost deleted the ss/p6-bug-fixes branch August 14, 2023 10:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants