Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary setup section, duplicate #1126

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dragosgd
Copy link
Contributor

Purpose

Update SFT tutorial

Changes

  • removed unnecessary setup section, it was not needed as user is already redirected in the index to our separate setup tutorial
  • tutorial was mentioning that the cis2-nft was used, which is wrong, as cis2-multi was actually used, rectified this
  • fixed one small typo
  • this tutorial is not completed, code might have to be modified in the future in order to be up to date, still in review

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dragosgd dragosgd self-assigned this Nov 21, 2024
@dragosgd dragosgd requested a review from TinaKT November 21, 2024 15:59
Copy link
Contributor

@TinaKT TinaKT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dragosgd dragosgd merged commit 482ea1d into doc2 Nov 22, 2024
@dragosgd dragosgd deleted the doc2-tutorials-sftMinting branch November 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants