Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3 ID documentation #855

Merged
merged 52 commits into from
Sep 11, 2023
Merged

Web3 ID documentation #855

merged 52 commits into from
Sep 11, 2023

Conversation

dg-concordium
Copy link
Contributor

@dg-concordium dg-concordium commented Aug 3, 2023 •
edited
Loading

Purpose

Inform users about the introduction and usage of Web3 ID

Changes

New topics for Web3 ID

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dg-concordium dg-concordium added the preview Trigger a documentation preview for a PR. label Aug 11, 2023
@dg-concordium dg-concordium linked an issue Aug 11, 2023 that may be closed by this pull request
Web3 ID documentation #814
Closed
3 tasks
@dg-concordium
Copy link
Contributor Author

For those reviewing in preview, you will find the topics under Use Concordium's ID layer in the sidebar. Identity on Concordium is the introduction with three sub-topics. ID2.0 and Web3 ID have been merged together as much as possible.

@dg-concordium dg-concordium marked this pull request as ready for review September 5, 2023 08:34
@dg-concordium dg-concordium removed the preview Trigger a documentation preview for a PR. label Sep 6, 2023
@Concordium Concordium deleted a comment from github-actions bot Sep 6, 2023
@Concordium Concordium deleted a comment from github-actions bot Sep 8, 2023
@dg-concordium dg-concordium added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-11 14:20 UTC

abizjak
abizjak approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Another minor point:
source/mainnet/net/images/browser-wallet/add-web3id-credential-sign.png

is not used anymore I think.

source/mainnet/net/resources/glossary.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/create-proofs.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/create-proofs.rst Show resolved Hide resolved
source/mainnet/net/guides/create-proofs.rst Outdated Show resolved Hide resolved
source/mainnet/net/guides/create-proofs.rst Outdated Show resolved Hide resolved
source/mainnet/net/web3-id/issuer.rst Outdated Show resolved Hide resolved
source/mainnet/net/web3-id/issuer.rst Outdated Show resolved Hide resolved
source/mainnet/net/web3-id/issuer.rst Outdated Show resolved Hide resolved
source/mainnet/net/web3-id/wallet.rst Outdated Show resolved Hide resolved
source/mainnet/net/web3-id/wallet.rst Outdated Show resolved Hide resolved
dg-concordium and others added 10 commits September 11, 2023 08:33
@dg-concordium @abizjak
Update source/mainnet/net/guides/create-proofs.rst
c040166 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium @abizjak
Update source/mainnet/net/guides/create-proofs.rst
60bcbb5 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium @abizjak
Update source/mainnet/net/guides/create-proofs.rst
12696c5 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium @abizjak
Update source/mainnet/net/guides/create-proofs.rst
f1d48bf 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium @abizjak
Update source/mainnet/net/release-notes/release-notes-lp.rst
dfb19ae 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium @abizjak
Update source/mainnet/net/web3-id/concordia.rst
3ec6cec 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium @abizjak
Update source/mainnet/net/web3-id/index.rst
335ef63 
Co-authored-by: Aleš Bizjak <[email protected]>
@dg-concordium
Address review comments
4bbcd75
@dg-concordium
Merge branch 'main' into web3-id
e7f8ddb
@dg-concordium
Update release-notes-lp.rst
23a3d30
mh-concordium
mh-concordium requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@mh-concordium mh-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment, I have extended a section including new issuers frontends.. Otherwise, it looks great.

source/mainnet/net/web3-id/concordia.rst Outdated Show resolved Hide resolved
mh-concordium
mh-concordium approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@mh-concordium mh-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dg-concordium dg-concordium merged commit 553a7ad into main Sep 11, 2023
2 checks passed
@dg-concordium dg-concordium deleted the web3-id branch September 11, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoleta-andreiana nicoleta-andreiana nicoleta-andreiana approved these changes

@mh-concordium mh-concordium mh-concordium approved these changes

@abizjak abizjak abizjak approved these changes

@orhoj orhoj Awaiting requested review from orhoj

@ali-concordium ali-concordium Awaiting requested review from ali-concordium

@shjortConcordium shjortConcordium Awaiting requested review from shjortConcordium

Assignees
No one assigned
Labels
preview Trigger a documentation preview for a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web3 ID documentation
5 participants
@dg-concordium @abizjak @shjortConcordium @mh-concordium @nicoleta-andreiana