Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go package option to opencdc.proto #8

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add go package option to opencdc.proto #8

merged 1 commit into from
Jan 3, 2024

Conversation

lovromazgon
Copy link
Member

The title says it all. Relevant discussion: #7 (comment).

@lovromazgon lovromazgon requested a review from a team as a code owner January 3, 2024 19:15
@lovromazgon lovromazgon mentioned this pull request Jan 3, 2024
Merged
4 tasks
@lovromazgon
Copy link
Member Author

Linter complains:

Error: File option "go_package" changed from "" to "github.com/conduitio/conduit-commons/proto/opencdc/v1".

Yes, that's the whole point of this PR 🙄

@lovromazgon lovromazgon enabled auto-merge (squash) January 3, 2024 19:17
@lovromazgon lovromazgon merged commit 8f84b3f into main Jan 3, 2024
4 of 5 checks passed
@lovromazgon lovromazgon deleted the lovro/opencdc-proto-go-package branch January 3, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuboxa lyuboxa lyuboxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovromazgon @lyuboxa