Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specgen #211

Merged
merged 12 commits into from
Dec 23, 2024
Merged

specgen #211

merged 12 commits into from
Dec 23, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Nov 15, 2024

specgen is a tool that builds a YAML that contains all the important information about a connector. The file, called connector.yaml, is build from the source and destination configuration structs of a connector.

This code combines the code from #198 (which is the major part) plus some additional tests.

A detailed description of specgen can be found here: #198.

* specgen spike

* start nicer rewrite of specgen

* support for parsing builtin params

* support for time.Duration

* support types in different packages

* support underlying type

* better tests

* specgen specification parsing and default overwriting

* add support for destinations

* fix test

* add parsing and validation of config

* adjust most destination tests

---------

Co-authored-by: Haris Osmanagic <[email protected]>
@hariso hariso changed the title specgen [WIP] specgen Nov 15, 2024
@hariso hariso changed the title [WIP] specgen specgen Dec 9, 2024
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariso looking great. Let me know if you need me to approve ahead of time in case you need to release it while other people is away.

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ahead of time to unblock @hariso

@hariso hariso marked this pull request as ready for review December 20, 2024 10:13
@hariso hariso requested a review from a team as a code owner December 20, 2024 10:13
@hariso hariso merged commit 9d9a69d into main Dec 23, 2024
3 checks passed
@hariso hariso deleted the specgen branch December 23, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants