Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add schema tests #64

Merged
merged 4 commits into from
Jul 26, 2024
Merged

add schema tests #64

merged 4 commits into from
Jul 26, 2024

Conversation

maha-hajja
Copy link
Contributor

Description

Related to #45

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner July 24, 2024 05:14
lovromazgon
lovromazgon approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially we're testing the in-memory schema registry, but ok, the tests don't hurt.

@maha-hajja maha-hajja requested a review from lovromazgon July 25, 2024 21:15
lovromazgon
lovromazgon approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@lovromazgon lovromazgon merged commit c255043 into main Jul 26, 2024
5 checks passed
@lovromazgon lovromazgon deleted the maha/schema-tests branch July 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maha-hajja @lovromazgon