Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty author bug #2100

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix empty author bug #2100

merged 2 commits into from
Jan 24, 2025

Conversation

maha-hajja
Copy link
Contributor

Description

hard to find, easy to fix :D

Fixes #2090

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner January 24, 2025 01:03
raulb
raulb approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this is now shown, thank you @maha-hajja !

$ conduit processor-plugins desc builtin:[email protected] | grep Author
Author: Meroxa, Inc.

@raulb raulb enabled auto-merge (squash) January 24, 2025 10:15
@raulb raulb merged commit 5a1710b into main Jan 24, 2025
3 checks passed
@raulb raulb deleted the maha/fix-missing-author branch January 24, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Author is always empty
2 participants
@maha-hajja @raulb