Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usage parameters #2125

Merged
merged 5 commits into from
Feb 5, 2025
Merged

add usage parameters #2125

merged 5 commits into from
Feb 5, 2025

Conversation

maha-hajja
Copy link
Contributor

Description

when running ./conduit pipelines desc --help , the Usage doesn't show the required
this PR adds this for all the desc commands, and pipelines init

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner February 4, 2025 21:05
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maha-hajja . I'd rather indicate placeholders in capital letters https://developers.google.com/style/placeholders.

e.g.:

describe CONNECTOR_PLUGIN_ID or describe [CONNECTOR_PLUGIN_ID] when optional.

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated. Hope you don't mind @maha-hajja so we could ship it earlier.

@raulb raulb enabled auto-merge (squash) February 5, 2025 10:32
@raulb raulb merged commit de1579d into main Feb 5, 2025
3 checks passed
@raulb raulb deleted the maha/mini-fixes branch February 5, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants