Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache hit metrics and eth_call to client middleware #251

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

wanliqun
Copy link
Contributor

@wanliqun wanliqun commented Nov 28, 2024

  • Integrate eth_call handling in cache middleware
  • Add metrics to monitor cache hit ratio
  • Support caching of RPC errors alongside result data

This change is Reviewable

- Integrate `eth_call` handling in the client cache middleware
- Add metrics to track and monitor the cache hit ratio
@wanliqun wanliqun requested a review from boqiu November 28, 2024 10:44
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wanliqun)

@wanliqun wanliqun merged commit c5fbf0d into main Nov 28, 2024
2 checks passed
@wanliqun wanliqun deleted the improve-eth-call-cache branch November 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants