Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whitelist expression to include 404s on images when using Roku (and Swiftfin?) #1

Merged

Conversation

ConfusedOwlet
Copy link
Owner

Basically just a fix for jellyfin/jellyfin-roku#1911 (and potentially jellyfin/Swiftfin#690 // jellyfin/Swiftfin#884 ??) until the Jellyfin devs can potentially try to fix it on their end.

The regex was primarily created by Nabeora over on the Crowdsec Discord, they just mentioned how to make it fully case insensitive, and I tweaked it to match. This was originally just for the Jellyfin-Roku app, however I saw the issue in the Swiftfin github and saw we basically had the same logs/errors.

my initial thread over on the Discord about this : https://discord.com/channels/921520481163673640/1277040020758200391

Sample logs you can use :

111.111.111 - - [24/Aug/2024:22:32:18 +0000] "GET /Items/5203a7e70b667d2cfaee2cd2eb3de082/Images/Primary?MaxHeight=330&MaxWidth=234&quality=90&Tags=null HTTP/2.0" 404 57 "-" "Roku/DVP-13.1 (13.1.4.01510-30)"
111.111.111 - - [24/Aug/2024:22:32:18 +0000] "GET /Items/af409665d3461f32d0c20c3ad9dcf514/Images/Primary?MaxHeight=330&MaxWidth=234&quality=90&Tags=null HTTP/2.0" 404 59 "-" "Roku/DVP-13.1 (13.1.4.01510-30)"
111.111.111 - - [24/Aug/2024:22:32:18 +0000] "GET /Items/fbef2493eb1b8191acf97cd81af4992f/Images/Primary?MaxHeight=330&MaxWidth=234&quality=90&Tags=null HTTP/2.0" 404 52 "-" "Roku/DVP-13.1 (13.1.4.01510-30)"

Logs from the Swiftfin issue (I tested them on my end and it looked like the filter worked. I'm not 100% sure if Swiftfin is still having this issue, however I did see that the original poster did mention earlier this year that it started doing it again)

111.111.111 - - [13/Jan/2024:23:17:58 +0100] "GET /Items/77c40737e58d0f8d03c5047ee17c4185/Images/primary?maxWidth=400 HTTP/2.0" 404 52 "-" "Swiftfin%20tvOS/70 CFNetwork/1490.0.4>
111.111.111 - - [13/Jan/2024:23:17:58 +0100] "GET /Items/09599d8dafff8b344fcc964f3d43e7c4/Images/primary?maxWidth=400 HTTP/2.0" 404 52 "-" "Swiftfin%20tvOS/70 CFNetwork/1490.0.4>
111.111.111 - - [13/Jan/2024:23:17:58 +0100] "GET /Items/4851eba90426dea053284919c7a53e40/Images/primary?maxWidth=400 HTTP/2.0" 404 52 "-" "Swiftfin%20tvOS/70 CFNetwork/1490.0.4>

@ConfusedOwlet
Copy link
Owner Author

hang on closing bc it doesn't look like it picked up the correct edits?

@ConfusedOwlet ConfusedOwlet reopened this Aug 25, 2024
@ConfusedOwlet ConfusedOwlet merged commit db1e8fb into ConfusedOwlet:update-jellyfin-whitelist Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants