Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement client search #118

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Implement client search #118

merged 7 commits into from
Feb 20, 2024

Conversation

michelleshx
Copy link
Contributor

Overview

Closes #96

  • clients page (with table of clients)
  • client search functionality (able to search by any column)

image
image
image

TODO

  • Need to link with the appropriate airtable "clients" table in api/clients/route.ts file (currently using test data)

@michelleshx michelleshx changed the title Client search Implement client search Feb 12, 2024
@WillieCubed WillieCubed self-requested a review February 16, 2024 23:16
@WillieCubed WillieCubed added this to the User Experience Sprint 2 milestone Feb 16, 2024
@WillieCubed WillieCubed enabled auto-merge (rebase) February 16, 2024 23:16
WillieCubed
WillieCubed requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@WillieCubed WillieCubed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Take a look at the comments for some requested changes.

src/components/ui/label.tsx Outdated Show resolved Hide resolved
src/components/ui/separator.tsx Show resolved Hide resolved
src/app/api/clients/route.ts Outdated Show resolved Hide resolved
src/app/api/clients/route.ts Outdated Show resolved Hide resolved
src/app/api/clients/route.ts Outdated Show resolved Hide resolved
src/app/dashboard/clients/page.tsx Outdated Show resolved Hide resolved
src/components/clientTable/ClientTable.tsx Outdated Show resolved Hide resolved
src/components/clientTable/columns.tsx Show resolved Hide resolved
src/components/clientTable/columns.tsx Outdated Show resolved Hide resolved
src/components/clientTable/columns.tsx Outdated Show resolved Hide resolved
@michelleshx michelleshx disabled auto-merge February 20, 2024 16:25
@michelleshx michelleshx enabled auto-merge (squash) February 20, 2024 16:29
WillieCubed
WillieCubed requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@WillieCubed WillieCubed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, but otherwise good to go!

src/components/clientTable/ClientTable.tsx Outdated Show resolved Hide resolved
src/lib/data/clients.ts Show resolved Hide resolved
@WillieCubed WillieCubed disabled auto-merge February 20, 2024 16:47
@WillieCubed WillieCubed enabled auto-merge (rebase) February 20, 2024 16:47
WillieCubed
WillieCubed approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@WillieCubed WillieCubed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WillieCubed WillieCubed merged commit 643a798 into develop Feb 20, 2024
1 check passed
@WillieCubed WillieCubed deleted the client-search branch February 20, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieCubed WillieCubed WillieCubed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Connie Prototype 2
Status: Done
Milestone
User Experience Sprint 2
Development

Successfully merging this pull request may close these issues.

Client Search
2 participants
@michelleshx @WillieCubed