Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simondlr
This PR:
CurationMarkets.sol
by splitting it in different files to help future developmentPlease note that I had to introduce two changes in order to make the contracts compile & deploy:
By compiling I faced the error
Internal compiler error: Accessors for mapping with dynamically-sized keys not yet implemented.
this is due to the fact that mapping doesn't support accessors where string is a key. So I had to creat a getter for totalBondsPerCuratorPerSubtopic
function getTotalBondsPerCuratorPerSubtopic(address _curator, string _subtopic) returns(uint256);
and remove the public accessor from it and from the bonds mapping. (more info: Raise useful error message when using a dynamic type as a key in a mapping ethereum/solidity#633)in
ContinuousToken
constructor the line// updateCostOfToken(0);
make run of gas the contract creation, so I changed it incostPerToken = 2 * baseCost;
it cames from the formula:
with an
initial AvailableSupply = 0
These are fixes just to make it compile and run. All the code still needs to be polish.