Nonce revert on sendAsync error #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5200,7 +5200,7 @@ var module = module || undefined; | |||
|
|
|||
| var __provisioner = { | |||
| provision_contracts: function(scope) { | |||
| scope.__contracts = JSON.parse("{\n \"Example\": {\n \"source\": \"/Users/tim/Documents/workspace/Consensys/hooked-web3-provider/contracts/Example.sol\",\n \"binary\": \"0x60606040525b5b60888060136000396000f30060606040526000357c010000000000000000000000000000000000000000000000000000000090048063130d6dc514604157806360fe47b114606057603f565b005b604a6004506071565b6040518082815260200191505060405180910390f35b606f600480359060200150607a565b005b60006000505481565b806000600050819055505b5056\",\n \"abi\": [\n {\n \"inputs\": [],\n \"constant\": true,\n \"name\": \"test_value\",\n \"outputs\": [\n {\n \"type\": \"uint256\",\n \"name\": \"\"\n }\n ],\n \"type\": \"function\"\n },\n {\n \"inputs\": [\n {\n \"type\": \"uint256\",\n \"name\": \"new_value\"\n }\n ],\n \"constant\": false,\n \"name\": \"set\",\n \"outputs\": [],\n \"type\": \"function\"\n },\n {\n \"inputs\": [],\n \"type\": \"constructor\"\n }\n ]\n }\n}"); | |||
| scope.__contracts = JSON.parse("{\n \"Example\": {\n \"source\": \"/Users/ck/consensys/noncense/persona-integration/myhooked/contracts/Example.sol\"\n }\n}"); | |||
There was a problem hiding this comment.
Hey @ckeenan. I don't think this change should have made it in. Can you tell me what version of Truffle you're using? Regardless, the build should be run using the latest version, as both the before and after have issues with the contract's source path.
There was a problem hiding this comment.
@tcoulter was using 0.1.0, rebuilding now w latest and removing truffle from package.json
This reverts commit 123d701.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps a copy of global_nonces in case of a transaction error so incremented nonces can be reverted
Removed rewritePayload & callback from synchronous
send()method since they never get usedAlso added truffle build command to package.json