Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug #16 #17

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

josh-davis-vicinft
Copy link

py-eip712-structs can handle structs that contain other structs and structs that contain arrays of primitives, but it breaks on structs that contain arrays of other structs.

This pull request fixes this.

Copy link

@shane-t shane-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shane-t
Copy link

shane-t commented Dec 22, 2022

@josh-davis-vicinft Thank you for your contribution! This bug often causes people to fork and modify the library. Unfortunately I don't have the ability to disable the pipeline (the original author has left, and it still seems to be linked to an old Travis account) and won't for a while as I'm on leave myself.

So it might be a few weeks before we can merge this and set up a new publication pipeline. Sorry for the delay!

@lukaskiss222
Copy link

When will you merge it?

@flipdazed
Copy link

still not merged ....?

@BoboTiG
Copy link

BoboTiG commented Jan 11, 2024

If you are still motivated, you could backport the fix to https://github.com/BoboTiG/py-eip712-structs-ng and I would be happy to cut a new release. If you do so, please add a test 🙏🏻

@BoboTiG
Copy link

BoboTiG commented Jan 12, 2024

Thanks @josh-davis-vicinft I backported part of that PR to BoboTiG/py-eip712-structs-ng@1c85ea2 in order to fix #16.

I'll cut a new release for that specific fix, and it someone can share a reproduction code for "...but it breaks on structs that contain arrays of other structs", I'll be happy to work on a second fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants