clean up minor component defaults and props #421

gesquinca · 2019-11-14T03:44:53Z

Release 0.10.0

for better debugging

- display correct uPort buttons for solid and outline

- include all font sizes. - include all font weights. - include tooltip variants.

- uses Box component as base now. - correctly forwards the 'as' prop. - removed redundant styled system props. - removed unnecessary default props.

- uses Text component as base now. - correctly forwards the 'as' prop. - removed unnecessary default props.

- likely a temporary fix

- use props inherited from Input for `color` and `bg` instead.

- use new `text` and `background` theme color values.

- removed `height` and `width` values to allow element to resize more naturally.

- hover color on icons displays correctly and `primary` color now. - text color on labels displays correctly as `text` color now.

netlify · 2019-11-14T03:48:15Z

Deploy preview for rimble-ui-storybook ready!

Built with commit b435d86

https://deploy-preview-421--rimble-ui-storybook.netlify.com

MikeLockz

Nice job on getting a bunch of bugs smashed. I think my biggest questions are what needs to be updated to the docs site with this release?

src/BaseStyles.js

src/Card/index.js

src/theme.js

src/Radio/index.js

storybook/stories/Button.stories.js

package.json

MikeLockz

Ready for release

gesquinca added 30 commits October 3, 2019 13:19

Merge pull request #371 from ConsenSys/development

dd470f0

Release 0.10.0

add styled components babel plugin

ec61025

for better debugging

configute styled components plugin

feecef7

re-ordered index.js

a774e0c

update demo app packages

b731126

add baseline grid component to demo

90c940c

adjust opacity of base line grid

2fa1991

seperate theme colors object for easier legibility

0564e30

simplify ThemeProvider component to essentials

bcb9b00

add componet to render base styling

9ebe41d

use new BaseStyles component in demo

db7fe75

Merge branch 'ge-base-styles' into ge-storybook-workshop

156d22f

added prop types to BaseStyles component

f0d7c8c

Merge branch 'ge-base-styles' into ge-storybook-workshop

eb35a77

remove background color application from base styles

c36e97c

Merge branch 'ge-base-styles' into ge-storybook-workshop

c0fa408

added uPort buttons to demo app

bb56add

updated Button stories

45e21c2

- display correct uPort buttons for solid and outline

updated demo app

bbe85e2

- include all font sizes. - include all font weights. - include tooltip variants.

Merge branch 'development' into ge-default-props-cleanup

c869058

updated code formatting

a9b86ca

seperated typographic components

8b98bd4

updated Text component

b95fbf6

- uses Box component as base now. - correctly forwards the 'as' prop. - removed redundant styled system props. - removed unnecessary default props.

updated Heading component

1fadae0

- uses Text component as base now. - correctly forwards the 'as' prop. - removed unnecessary default props.

added default font sizes to BaseStyles

48b558e

- likely a temporary fix

updated Textarea default props

4fef501

- use props inherited from Input for `color` and `bg` instead.

updated Input default props

b27a98e

- use new `text` and `background` theme color values.

removed copyColor theme value

5681948

updated Card default props

bd9c9cc

- removed `height` and `width` values to allow element to resize more naturally.

updated color values for Radio and Checkbox

c549edf

- hover color on icons displays correctly and `primary` color now. - text color on labels displays correctly as `text` color now.

gesquinca added 2 commits November 13, 2019 22:05

updated padding for eth address input

ba3d5c6

added width properties to Select component

7de8cc9

gesquinca requested a review from MikeLockz November 14, 2019 03:44

gesquinca self-assigned this Nov 14, 2019

updated snapshot tests

b435d86

gesquinca added the bug Something isn't working label Nov 14, 2019

MikeLockz reviewed Nov 14, 2019

View reviewed changes

src/BaseStyles.js Show resolved Hide resolved

src/Card/index.js Show resolved Hide resolved

src/theme.js Show resolved Hide resolved

src/Radio/index.js Show resolved Hide resolved

storybook/stories/Button.stories.js Show resolved Hide resolved

package.json Show resolved Hide resolved

MikeLockz mentioned this pull request Nov 14, 2019

Added default fontSize to Heading #389

Closed

MikeLockz approved these changes Nov 15, 2019

View reviewed changes

gesquinca merged commit 365a770 into development Nov 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clean up minor component defaults and props #421

clean up minor component defaults and props #421

gesquinca commented Nov 14, 2019

netlify bot commented Nov 14, 2019 •

edited

Loading

MikeLockz left a comment

MikeLockz left a comment

clean up minor component defaults and props #421

clean up minor component defaults and props #421

Conversation

gesquinca commented Nov 14, 2019

netlify bot commented Nov 14, 2019 • edited Loading

MikeLockz left a comment

Choose a reason for hiding this comment

MikeLockz left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 14, 2019 •

edited

Loading