Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expressions in modifier arguments #28

Merged
merged 2 commits into from
Nov 23, 2016
Merged

Allow expressions in modifier arguments #28

merged 2 commits into from
Nov 23, 2016

Conversation

raineorshine
Copy link
Contributor

@raineorshine raineorshine commented Nov 21, 2016

Fix for #27

e.g.

contract MyContract {
  function fun() mymodifier(foo.bar()) {}
}

@tcoulter
Copy link
Contributor

Awesome @raineorshine. Can you add the above code example into https://github.com/ConsenSys/solidity-parser/blob/master/test/doc_examples.sol, which is the catch all for testing to assure we can parse everything in that file?

It's not a great way to test each feature, but it's good enough for now.

@raineorshine
Copy link
Contributor Author

Ready to merge

@tcoulter tcoulter merged commit cf1c2e2 into ConsenSysMesh:master Nov 23, 2016
@tcoulter
Copy link
Contributor

Thanks @raineorshine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants