Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added how to load YubiHSM and fixed key config file names #249

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Added how to load YubiHSM and fixed key config file names #249

merged 3 commits into from
Dec 13, 2023

Conversation

MadelineMurray
Copy link
Contributor

Fixes #213

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-web3signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:36pm

usmansaleem
usmansaleem approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran self-assigned this Dec 13, 2023
@alexandratran
edits and formatting
5ebc232 
Signed-off-by: Alexandra Tran <[email protected]>
@alexandratran
update project-words.txt
4af2f32 
Signed-off-by: Alexandra Tran <[email protected]>
alexandratran
alexandratran approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some edits, LGTM

@MadelineMurray MadelineMurray merged commit 9aa86fd into Consensys:main Dec 13, 2023
9 checks passed
@MadelineMurray MadelineMurray deleted the 213FixYubiHSMDocs branch December 13, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@usmansaleem usmansaleem usmansaleem approved these changes

@bgravenorst bgravenorst Awaiting requested review from bgravenorst

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix YubiHSM docs
3 participants
@MadelineMurray @usmansaleem @alexandratran