Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java version #270

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Update Java version #270

merged 3 commits into from
Aug 16, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

Fixes #269

@vercel Vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-web3signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 10:52am

@joaniefromtheblock
Copy link
Contributor Author

@usmansaleem please review when you have a chance. Thanks a million

usmansaleem
usmansaleem approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m4sterbunny
m4sterbunny approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@m4sterbunny m4sterbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaniefromtheblock joaniefromtheblock merged commit 5b99e88 into main Aug 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4sterbunny m4sterbunny m4sterbunny approved these changes

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Web3Signer build requirements to Java 21
3 participants
@joaniefromtheblock @usmansaleem @m4sterbunny