Vale #44
Merged
Vale #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
m4sterbunny
commented
Sep 10, 2024
|
|
||
| WIP: That GHA repo should be set up to apply the [Vale linting set](https://github.com/ConsenSys/docs-gha/tree/main/spelling). | ||
|
|
||
| ### Let's Upset Vale |
There was a problem hiding this comment.
Not sure this will upset Vale
I think it may be constrained to look in the stated folders only and README aint in one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Josh and Harrie working on upstream linting and validating it here.
@joshuafernandes I think we have chicken::egg issue here. I wanted to test Vale against this PR BUT this PR has the instruction to expand the lint branch to include vale.
Does that mean we need to merge this first, or merge alt PR on main and merge main with this?