-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/poseidon2 #1300
base: master
Are you sure you want to change the base?
Feat/poseidon2 #1300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! the PR follows Consensys/gnark-crypto#553 (review). Next we need to use poseidon2 in other places (commitment, recursion, signature, gkr...) and do some benchmarks.
README.md
Outdated
@@ -85,7 +85,7 @@ You can also get in touch directly: [email protected] | |||
* [OpenZeppelin - November 2023 - gnark PLONK Solidity verifier template](https://blog.openzeppelin.com/linea-verifier-audit-1) | |||
* [ZKSecurity.xyz - May 2024 - gnark standard library](audits/2024-05%20-%20zksecurity%20-%20gnark%20std.pdf) | |||
* [OpenZeppelin - June 2024 - gnark PLONK prover and verifier](https://blog.openzeppelin.com/linea-prover-audit) | |||
* [LeastAuthority - July 2024 - gnark general and GKR (initial report)](audits/2024-07%20-%20Least%20Authority%20-%20arithm%20and%20GKR.pdf) | |||
* [LeastAuthority - September 2024 - gnark general and GKR](audits/2024-09%20-%20Least%20Authority%20-%20arithm%20and%20GKR.pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the branch be rebased on master?
Description
Implementation of poseidon2 for t=2,3 following
reference implementation
reference paper
TBD: algos 1, 2, 3 of https://tosc.iacr.org/index.php/ToSC/article/view/8913/8489 for finding internal matrices when t>3
see gnark-crypto's corresponding PR
Type of change
How has this been tested?
see
TestPoseidon2
, tested against gnark-crypto's implementationHow has this been benchmarked?
scs: 632 constraints for t=3
r1cs: 243 constraints for t=3
Checklist:
golangci-lint
does not output errors locally