Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fast path operations for small non-native values #1326

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Nov 22, 2024

Description

This PR enforces small non-native values to work on zero or one limb. I also added some fast-path operations when we can deduce the result without needing to perform any operations (mul by zero for example).

Also adds a few more emulation parameters useful for implementing small-fields.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Existing tests succeed

How has this been benchmarked?

Updated the stats.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the consolidate strengthen an existing feature label Nov 22, 2024
@ivokub ivokub added this to the v0.11.N milestone Nov 22, 2024
@ivokub ivokub requested a review from gbotrel November 22, 2024 22:58
@ivokub ivokub self-assigned this Nov 22, 2024
@ivokub ivokub marked this pull request as ready for review November 22, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant