Refac/groth16 mpc

[Tabaie]

Description

#1297, but using tools from Consensys/gnark-crypto#589.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested?

• Test A
• Test B

How has this been benchmarked?

• Benchmark A, on Macbook pro M1, 32GB RAM
• Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I did not modify files generated from templates
• golangci-lint does not output errors locally
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[ivokub]

Thanks for addressing the comments! It looks almost perfect now!

There are still some things I'm not sure about - one is that imo we're doing subgroup checks several times when using deserialized inputs. And I think that we could save a lot of memory when doing some operations inline instead of precomputing all the scalars. And lastly one thing about failing early in worker pools. See the inlined comments (i also unresolved some to continue discussion)

[ivokub]

Thank you very much @Tabaie for addressing the issues. Sorry for the long back and forth. There are still some performance optimisations and additional features, but I have collected them in #1428 for now. See if there is something missing there.

Good to merge from my side.

[Tabaie]

Thank you for the detailed review @ivokub!